-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register migrateImport
to ensure it actually runs
#14769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
force-pushed
the
fix/register-migrate-import
branch
from
October 23, 2024 19:10
1bf5560
to
190582d
Compare
philipp-spiess
previously approved these changes
Oct 23, 2024
When testing this manually (when we finally figured out how to do that locally, spoiler this was very hard), we noticed a bunch of warnings still that aren't surfaced when running the tests, because our So this isn't actually ready to go yet, we're going to want to resolve that before merging. |
philipp-spiess
force-pushed
the
fix/register-migrate-import
branch
from
October 24, 2024 11:32
aa22971
to
fa5549c
Compare
@adamwathan Pushed two changes onto this branch just now:
|
adamwathan
commented
Oct 24, 2024
philipp-spiess
force-pushed
the
fix/register-migrate-import
branch
from
October 24, 2024 14:28
81b7124
to
9ece083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure the
migrateImport
codemod is properly registered so that it runs as part of the upgrade process.Test plan
This PR adds a new
v3
playground with anupgrade
script that you can use to run the upgrade from the local package. When you add a non-prefixed@import
to the v3 example, the paths are now properly updated with no errors logged:Screen.Recording.2024-10-24.at.13.28.03.mov